Tasklist

FS#19 - user-autocompletion not working in advanced search (+ JS error in Firefox), with diagnose

Attached to Project: Flyspray JE
Opened by Beat (beat) - Wednesday, 22 August 2007, 13:36 GMT+2
Last edited by Krishan (Krishan) - Wednesday, 29 August 2007, 20:54 GMT+2
Task Type Bug Report
Category Backend/Core
Status Closed
Assigned To Krishan (Krishan)
Operating System All browsers
Severity Medium
Priority Normal
Reported Version 1.0.3
Due in Version 1.0.4
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

User-autocompletion in advanced search doesn’t work.

But more anoyingly (try accessing this tracker list with Firefox and errors-reporting on to reproduce), it generates JS bugs.

This is due to a wrong regex replacement:

This has as result that in the html, this:

  new Ajax.Autocompleter('opened', 'opened_complete', 'index.php?option=com_flyspray&Itemid=4&option=com_flyspray&ajaxurl=', {})

is replaced by that:

  new Ajax.Autocompleter('index.php?option=com_flyspray&Itemid=4&option=com_flyspray&ajaxtask=usersearch&', {})

instead of this:

  new Ajax.Autocompleter('opened', 'opened_complete','index.php?option=com_flyspray&Itemid=4&option=com_flyspray&ajaxtask=usersearch', {})

Tracked this down to this regexp line 147 of flyBridge.class.php :

								 	 "#'index.php?option=com_flyspray&Itemid=4&*#"

A few improvements needed:

1) the 2 first arguments are
&amp shouldn’t be used in js (this of course gives xhtml validation errors, so you need to html-comment the
the last & shouldn’t be
the domain name is missing in the replace, so with SEF on, it might not work at all (btw sefRelToAbs is missing).

This task depends upon

Closed by  Krishan (Krishan)
Wednesday, 29 August 2007, 20:54 GMT+2
Reason for closing:  Fixed
Comment by Krishan (Krishan) - Wednesday, 29 August 2007, 20:54 GMT+2

thanks for the hints. 1) to 3) is corrected in 1.0.4

I have no experience with SEF. normal pages don’t have problems without the domain name and SEF shouldn’t be problematic as well. Till now there are no bugs mentioned for this. I therefore wait if anybody gets problems with SEF.

Loading...